Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
PWC may need fine-tuned control over the maximum size of bottom sheets. We had a private constant that controlled this, but now it's a public variable that's part of the sheet's appearance.
Purpose
Fix #21 Move the private minimumTopOffset constant from BottomSheetController to Appearance and make it a public variable.
Scope
Discussion
The issue says to also move minimumContentHeight to Appearance, but it is already there serving a related but slightly different purpose, so I just switched it from
private let
topublic var
in BottomSheetController.There are also a few cleanup items I did:
init(coder:)
methods as unavailable and removed their unit tests📱 Screenshots
Sheet appearance is unchanged.
📈 Coverage
Code
100%
Documentation
100%