Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM-1243] Support for reduce motion accessibility. #15

Merged
merged 4 commits into from
Mar 23, 2023

Conversation

devyml
Copy link
Collaborator

@devyml devyml commented Mar 23, 2023

Introduction

When reduce motion accessibility feature is enabled we are fading the sheet in and out instead of sliding it on/off the bottom of the screen.

Purpose

Scope

we are disabling the sliding animation if reduce motion accessibility is enabled.

🎬 Video

reduce motion

📈 Coverage

Code

Screenshot 2023-03-23 at 12 31 51 PM

Documentation

Screenshot 2023-03-23 at 12 36 03 PM

@devyml devyml self-assigned this Mar 23, 2023
@devyml devyml added the enhancement New feature or request label Mar 23, 2023
Copy link
Contributor

@mpospese mpospese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed the translation animation, but didn't add in the fade in/out animations.

@devyml devyml requested a review from mpospese March 23, 2023 11:38
Copy link
Contributor

@mpospese mpospese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please check how I tested the animators both with and without reduce motion enabled.

Copy link

@WestonHanners WestonHanners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure the elimination of all motion is really in the spirit of "reduce motion" I think a crossfade might make sense as it is what Apple does.

Copy link

@WestonHanners WestonHanners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please investigate implementing a crossfade for reduced motion preference.

@devyml
Copy link
Collaborator Author

devyml commented Mar 23, 2023

Looks good. Please check how I tested the animators both with and without reduce motion enabled.

Sure @mpospese

@WestonHanners
Copy link

I was making my crossfade comments based on the old gif, after seeing it in action, I retract my previous request. This PR looks good 👍

@mpospese
Copy link
Contributor

@devyml You should have updated the gif in the description when we fixed the behavior.
2023-03-23 15 10 50

@devyml devyml merged commit 69aa5ac into main Mar 23, 2023
@devyml devyml deleted the feature/CM-1243-motionAccessibilityFeature branch March 23, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Add Support for Reduce Motion Accessibility Feature
3 participants