-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CM-1243] Support for reduce motion accessibility. #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You removed the translation animation, but didn't add in the fade in/out animations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please check how I tested the animators both with and without reduce motion enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure the elimination of all motion is really in the spirit of "reduce motion" I think a crossfade might make sense as it is what Apple does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please investigate implementing a crossfade for reduced motion preference.
Sure @mpospese |
I was making my crossfade comments based on the old gif, after seeing it in action, I retract my previous request. This PR looks good 👍 |
@devyml You should have updated the gif in the description when we fixed the behavior. |
Introduction
When reduce motion accessibility feature is enabled we are fading the sheet in and out instead of sliding it on/off the bottom of the screen.
Purpose
Scope
we are disabling the sliding animation if reduce motion accessibility is enabled.
🎬 Video
📈 Coverage
Code
Documentation