Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 22] Fix bottom sheet height for navigation and table controllers #27

Merged
merged 7 commits into from
May 4, 2023

Conversation

mpospese
Copy link
Contributor

@mpospese mpospese commented May 3, 2023

Introduction

When displaying a navigation controller or a table view controller in the bottom sheet, the sheet doesn't size itself correctly.

Purpose

Fix #22

Scope

  • Move sheet size constraint properties from appearance to layout
  • Expand these constraint properties to include minimum, ideal, and maximum content sizes
  • Add mechanism for different views and view controllers to report their ideal size
  • Separate the view that has masked corners (must be clipped) from the view that has the sheet's shadow (clipping removes any shadow so cannot be the same view as the one clipping the corners)

Out of Scope

Call out any known issues that are purposely not addressed in this pull request.

📱 Screenshots

Test Case Before After
Navigation bs_22_before_3 bs_22_after_3
Table with 4 items (note missing corner curve) bs_22_before_4 bs_22_after_4
Navigation + Table with 4 items bs_22_before_5 bs_22_after_5

📈 Coverage

Code

100%

image

Documentation

100%

image

@mpospese mpospese merged commit 7c61299 into main May 4, 2023
@mpospese mpospese deleted the issue/22-height-delegate branch May 4, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix sheet sizing with navigation and table controllers
2 participants