Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
We should make our bottom sheet animations even more customizable than they already are by leveraging the
Animation
struct that's already in YCoreUI (and used by Y—Snackbar and Y—SideMenu).Purpose
Fix #26 Use new
Animation
structure for present / dismiss animations.Scope
Animation
with default values for bottom sheetAppearance
to useAnimation
instead of separate duration and curve propertiesDiscussion
One thing this allows (which wasn't possible before) is to optionally present bottom sheets using spring animations. We also have the flexibility (should we need it) to have not only different curves but different durations for the present and dismiss animations. The default behavior though is unchanged: animations are 0.3 seconds and .easeIn on present / .easeOut on dismiss.
🎬 Video
(These animations are slowed down by 2x to help them appear better as GIFs)
📈 Coverage
Code
100%
Documentation
100%