Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not found http client definition on Android #52

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

osugikoji
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This Pull Request replaces the Java Http Engine with the OkHttp Engine to support Android and JVM platforms.

💡 Motivation and Context

This fix addresses the issue reported in #51.

💚 How did you test it?

I generated artifacts locally and tested the generated dependency on iOS, JVM, and Android platforms.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • All linters passing
  • There are no code climate issues

@osugikoji osugikoji merged commit 63d1cc5 into main Mar 21, 2023
@osugikoji osugikoji deleted the fix/crash-http-client branch March 21, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

NoClassDefFoundError: Failed resolution of: Ljava/net/http/HttpClient$Version;
2 participants