-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CM 1206] Add additional shapes #4
Conversation
[UPDATE] added shapes without stroke, test case updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, let's just add scaledRoundRect as well to have the option of a uniform experience even as text scales.
db4593c
to
60abe95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Let's add the necessary white space and not scale the border width.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
Introduction
Add support for shapes other than capsule.
Purpose
To add four shape options as 1. none 2. rectangle 3. round rect 4. scaled rounded rect 5. capsule (default).
Scope
User can now choose shape of stepper
📱 Screenshots
Different shapes supported.
📈 Coverage
Code
~98% code coverage.
Documentation
100% public APIs documentation.