Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM 1206] Add additional shapes #4

Merged
merged 6 commits into from
Mar 16, 2023

Conversation

SahilSainiYML
Copy link
Contributor

@SahilSainiYML SahilSainiYML commented Mar 16, 2023

Introduction

Add support for shapes other than capsule.

Purpose

To add four shape options as 1. none 2. rectangle 3. round rect 4. scaled rounded rect 5. capsule (default).

Scope

User can now choose shape of stepper

📱 Screenshots

Different shapes supported.
Shape -  none
shape-  rounded rect
Scaled Rounded rect
Shape-  rectangle
Shape capsule

📈 Coverage

Code

~98% code coverage.
code coverage

Documentation

100% public APIs documentation.
Jazzy report

Copy link
Contributor

@mpospese mpospese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, let's just add scaledRoundRect as well to have the option of a uniform experience even as text scales.

Sources/YStepper/UIKit/YStepper+Shapes.swift Show resolved Hide resolved
Tests/YStepperTests/Views/StepperTests.swift Outdated Show resolved Hide resolved
Tests/YStepperTests/Views/StepperTests.swift Outdated Show resolved Hide resolved
@SahilSainiYML SahilSainiYML force-pushed the feature/CM-1206-AddAdditionalShapes branch from db4593c to 60abe95 Compare March 16, 2023 07:42
Copy link
Contributor

@mpospese mpospese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Let's add the necessary white space and not scale the border width.

Sources/YStepper/SwiftUI/Views/Stepper.swift Outdated Show resolved Hide resolved
Sources/YStepper/SwiftUI/Views/Stepper.swift Outdated Show resolved Hide resolved
Sources/YStepper/SwiftUI/Views/Stepper.swift Outdated Show resolved Hide resolved
Sources/YStepper/SwiftUI/Views/Stepper.swift Outdated Show resolved Hide resolved
Sources/YStepper/SwiftUI/Views/Stepper.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@mpospese mpospese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@SahilSainiYML SahilSainiYML merged commit cdd8ed6 into main Mar 16, 2023
@SahilSainiYML SahilSainiYML deleted the feature/CM-1206-AddAdditionalShapes branch March 16, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants