V9.0.0/depedency bump #3
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| using System.ComponentModel.DataAnnotations; | ||
|
|
||
| namespace Codebelt.Extensions.AspNetCore.Mvc.Formatters.Newtonsoft.Json.Assets | ||
| { | ||
| public class SampleModel | ||
| { | ||
| [Required(ErrorMessage = "This field is required.")] | ||
| [StringLength(100)] | ||
| public string Name { get; set; } | ||
| } | ||
| } | ||
|
Comment on lines
+5
to
+11
There was a problem hiding this comment. 🛠️ Refactor suggestion Consider enhancing the model for improved testability. While the current implementation is sufficient for basic testing, consider the following enhancements to improve the model's usability in tests:
Here's an example of how you could implement these suggestions: public class SampleModel
{
[Required(ErrorMessage = "This field is required.")]
[StringLength(100, ErrorMessage = "The name cannot exceed 100 characters.")]
public string Name { get; set; }
public SampleModel() { }
public SampleModel(string name)
{
Name = name;
}
public override string ToString()
{
return $"SampleModel {{ Name = {Name} }}";
}
}These additions would make the model more versatile for various testing scenarios. |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| using System; | ||
| using System.Reflection; | ||
| using Cuemon.AspNetCore.Http; | ||
| using Microsoft.AspNetCore.Mvc; | ||
|
|
||
| namespace Codebelt.Extensions.AspNetCore.Mvc.Formatters.Newtonsoft.Json.Assets | ||
| { | ||
| [ApiController] | ||
| [Route("[controller]")] | ||
| public class StatusCodesController : ControllerBase | ||
| { | ||
| [HttpGet("400")] | ||
| public IActionResult Get_400() | ||
| { | ||
| throw new BadRequestException(new ArgumentNullException()); | ||
| } | ||
|
|
||
| [HttpGet("401")] | ||
| public IActionResult Get_401() | ||
| { | ||
| throw new UnauthorizedException(new AccessViolationException()); | ||
| } | ||
|
|
||
| [HttpGet("403")] | ||
| public IActionResult Get_403() | ||
| { | ||
| throw new ForbiddenException(new UnauthorizedAccessException()); | ||
| } | ||
|
|
||
| [HttpGet("404")] | ||
| public IActionResult Get_404() | ||
| { | ||
| throw new NotFoundException(new NullReferenceException()); | ||
| } | ||
|
|
||
| [HttpGet("405")] | ||
| public IActionResult Get_405() | ||
| { | ||
| throw new MethodNotAllowedException(new ArgumentException()); | ||
| } | ||
|
|
||
| [HttpGet("406")] | ||
| public IActionResult Get_406() | ||
| { | ||
| throw new NotAcceptableException(new ArgumentException()); | ||
| } | ||
|
|
||
| [HttpGet("409")] | ||
| public IActionResult Get_409() | ||
| { | ||
| throw new ConflictException(new AmbiguousMatchException()); | ||
| } | ||
|
|
||
| [HttpGet("410")] | ||
| public IActionResult Get_410() | ||
| { | ||
| throw new GoneException(new NotImplementedException()); | ||
| } | ||
|
|
||
| [HttpGet("412")] | ||
| public IActionResult Get_412() | ||
| { | ||
| throw new PreconditionFailedException(new ArgumentOutOfRangeException()); | ||
| } | ||
|
|
||
| [HttpGet("413")] | ||
| public IActionResult Get_413() | ||
| { | ||
| throw new PayloadTooLargeException(new ArgumentOutOfRangeException()); | ||
| } | ||
|
|
||
| [HttpGet("415")] | ||
| public IActionResult Get_415() | ||
| { | ||
| throw new UnsupportedMediaTypeException(new ArgumentOutOfRangeException()); | ||
| } | ||
|
|
||
| [HttpGet("428")] | ||
| public IActionResult Get_428() | ||
| { | ||
| throw new PreconditionRequiredException(new ArgumentException()); | ||
| } | ||
|
|
||
| [HttpGet("429")] | ||
| public IActionResult Get_429() | ||
| { | ||
| throw new TooManyRequestsException(new OverflowException()); | ||
| } | ||
|
|
||
| [HttpGet("XXX/{app}")] | ||
| public IActionResult Get_XXX(string app) | ||
| { | ||
| try | ||
| { | ||
| throw new ArgumentException("This is an inner exception message ...", nameof(app)) | ||
| { | ||
| Data = | ||
| { | ||
| { nameof(app), app } | ||
| }, | ||
| HelpLink = "https://www.savvyio.net/" | ||
| }; | ||
| } | ||
| catch (Exception e) | ||
| { | ||
| throw new NotSupportedException("Main exception - look out for inner!", e); | ||
| } | ||
| } | ||
|
|
||
| [HttpPost("/")] | ||
| public IActionResult Post(SampleModel model) | ||
| { | ||
| return Ok(model); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Residual 'Cuemon' references found in project files.
Several project files still reference "Cuemon" outside of expected PackageReference contexts:
test/Codebelt.Extensions.AspNetCore.Newtonsoft.Json.Tests/Codebelt.Extensions.AspNetCore.Newtonsoft.Json.Tests.csproj:<PackageReference Include="Cuemon.Extensions.AspNetCore.Authentication" Version="9.0.0-preview.9" />src/Codebelt.Extensions.AspNetCore.Newtonsoft.Json/Codebelt.Extensions.AspNetCore.Newtonsoft.Json.csproj:<PackageReference Include="Cuemon.Core" Version="9.0.0-preview.9" /><PackageReference Include="Cuemon.IO" Version="9.0.0-preview.9" /><Description>...complements the Cuemon.Extensions.AspNetCore/Cuemon.Extensions.Newtonsoft.Json namespace...</Description>Please update these references to "Codebelt" to ensure complete namespace restructuring.
🔗 Analysis chain
Namespace update in Description looks good.
The change from "Cuemon" to "Codebelt" in the namespace references is consistent with the PR objectives. This appears to be part of a larger rebranding or restructuring effort.
Let's verify if there are any remaining occurrences of "Cuemon" in the project files that might need updating:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 5164