Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes, removed 2 compiler warnings and code cleanup #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pmara84
Copy link

@pmara84 pmara84 commented Feb 8, 2013

  • The methods "decodeData:" and "decodeData:withError:" now return an NSInteger in order to remove compiler warnings.
  • "elementName:" now recalls "elementName:error:" in order to clean up the code and remove the crash in case "aXMLElement" is nil.
  • "attributeName:" now recalls "attributeName:error:" in order to clean up the code and remove the crash in case "aXMLAttribute" is nil.
  • "attributeValue:" now recalls "attributeValue:error:" in order to clean up the code and remove the crash in case "aXMLAttribute" is nil. Moreover a new error code has been added "D_TBXML_ATTRIBUTE_VALUE_IS_NIL" (with its related error description "Attribute value is nil"), in order to avoid a crash in case the value of an attribute is nil.
  • "textForElement:" now recalls "textForElement:error:" in order to clean up the code and remove the crash in case "aXMLElement" is nil.
  • "valueOfAttributeNamed:forElement:" now recalls "valueOfAttributeNamed:forElement:error:" in order to clean up the code and remove the crash in case "aName" or "aXMLElement" are nil. Moreover a compiler warning has been removed in this method.
  • "childElementNamed:parentElement:" now recalls "childElementNamed:parentElement:error:" in order to clean up the code and remove the crash in case "aName" or "aParentXMLElement" are nil.
  • "nextSiblingNamed:searchFromElement:" now recalls "nextSiblingNamed:searchFromElement:error:" in order to clean up the code and remove the crash in case "aName" or "aXMLElement" are nil.

- removed compiler warnings
- code cleanup
@CocoaBob
Copy link

CocoaBob commented Jul 4, 2013

Please merge this instead of #14 , it's implemented quite well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants