Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for Org in PayloadGenerator.ContactData #276

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

raganca
Copy link
Contributor

@raganca raganca commented Mar 8, 2021

This PR fixes/implements the following bugs/features:

  • Feature - Organization parameter for ContactData payload generator

What existing problem does the pull request solve?

No ability to generate a contact card with Organization.

Test plan
Ran unit tests with no issues.

I've successfully generated contact cards (VCard3) with the org parameter supplied.

Closing issues

Fixes #274

Copy link
Owner

@codebude codebude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please make the commented changes? Afterwards I will be happy to merge your request.

QRCoder/PayloadGenerator.cs Outdated Show resolved Hide resolved
QRCoderTests/PayloadGeneratorTests.cs Outdated Show resolved Hide resolved
QRCoderTests/PayloadGeneratorTests.cs Outdated Show resolved Hide resolved
QRCoderTests/PayloadGeneratorTests.cs Outdated Show resolved Hide resolved
QRCoderTests/PayloadGeneratorTests.cs Outdated Show resolved Hide resolved
QRCoderTests/PayloadGeneratorTests.cs Outdated Show resolved Hide resolved
QRCoderTests/PayloadGeneratorTests.cs Outdated Show resolved Hide resolved
Copy link
Owner

@codebude codebude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@codebude codebude merged commit 5729529 into codebude:master Apr 28, 2021
@codebude
Copy link
Owner

Thanks for your support @raganca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Organization in the ContactData payload
2 participants