Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to use WSEndpoint on Puppeteer #1350

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Add support to use WSEndpoint on Puppeteer #1350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/helper/Puppeteer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ const consoleLogStore = new Console();
*
* ```js
* "chrome": {
* "executablePath" : "/path/to/Chrome"
* "executablePath" : "/path/to/Chrome",
* "browserWSEndpoint": "ws://localhost:3000"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. Can you add here an example here for using CodeceptJS with browserless.io?

* }
* ```
*
Expand Down Expand Up @@ -376,7 +377,7 @@ class Puppeteer extends Helper {
}

async _startBrowser() {
this.browser = await puppeteer.launch(this.puppeteerOptions);
this.browser = this.puppeteerOptions.browserWSEndpoint ? await puppeteer.connect(this.puppeteerOptions) : await puppeteer.launch(this.puppeteerOptions);
this.browser.on('targetcreated', target => target.page().then(page => targetCreatedHandler.call(this, page)));
this.browser.on('targetchanged', (target) => {
this.debugSection('Url', target.url());
Expand Down