Add setting to reset artist-genre data #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #57, new artist-genre data is merged with existing data saved on the user's computer. However, I decided to add a setting to enable either the old or new behavior. With this PR, if the
ResetSavedArtistGenressetting istrue, then old data will be ignored and the file to be created anew. Otherwise, the old and new data will be merged (the current behavior). The default isfalse.I also found a genre sorting bug as part of this, which was causing the wrong genre to be selected and exported, so I have fixed this too. (I should eventually add some tests for this...)