no comment on PRs when using v5 #1662
Comments
|
Same happening for me for jwillemsen/daikin_onecta#350 |
|
I can confirm as well, though we have comments turned off, but the status check is also not reporting in. What I expect to see: And the statuses just never show up. On repos where branch protection is being used and the statuses are required for merging, this now means merging PRs would be blocked: I think this issue needs the "Priority: high" label. |
thomasrockhu-codecov
added
Urgent
|
Same issue for me and i check the codecov upload files in the website page, there is nothing uploaded. (action log says upload complete) |
|
Got it, sorry this is taking so long. I'm going to try to fix tomorrow morning. |
|
@thomasrockhu-codecov thanks for your work |
|
@ReenigneArcher @jwillemsen @jrfnl @dashdanw @yanyongyu @wbaldoumas ok, I released |
|
@thomasrockhu-codecov upgraded to v5.0.4, but it doesn't look like it resolved things: wbaldoumas/markdown-colorcode#174 |
|
@thomasrockhu-codecov unfortunately, there is still no PR comment with v5.0.4 LizardByte/libdisplaydevice#124 |
|
My experience is different in maplibre-gl-js. |
sure. it's nonebot/nonebot2#3119 |
|
@yanyongyu I'm a little confused, it looks like you are getting a PR comment on that link. |
|
@HarelM got it, that looks like an older version of the Action which probably means that the fixes we put in haven't hit. Are you still experiencing this issue? |
i just turn the token authentication option to not required, rerun the action, the upload and comment is success now. |
|
@thomasrockhu-codecov I just opened a PR to test if I get a comment if the app is disabled, and it didn't oost a comment: So I don't think it uses an older version. |
|
@HarelM just curious what you meant by disable the app, digging into this |
|
@HarelM if you mean the Codecov app, yeah it actually looks like something is going wrong with permissions. Can you uninstall the Codecov app and re-install it? Aside from that, everything looks fine to me. |
|
When I uninstall it, the comment does not appear. This wasn't the case for version 4. |
|
@HarelM hmmm, I don't think you will be able to get notification from Codecov without the app installed. Can you show me a screenshot specifically of what you mean by what you are install/uninstalling so that there's not a miscommunication? And as far marking a build as failing, what do you mean by that? Is there a specific Codecov status check that fails or something else? |
Ran once which failed, received an alert on the CodeCov link generated in the output when uploading that I needed to create a new commit, did so by rebasing via main and it worked! Thank you |
|
@thomasrockhu-codecov the following is the configuration in the org level, I mean install/uninstall when adding or removing the relevant repository from the list (in the following image it is installed on maplibre-gl-js, and other two repos): Here's an example where the app was working, but the build is marked as "red" (red x at the top), while I consider this build a success (if the app report was not part of the "CI runs" it would have been green) I've been in contact with the codecov team in the past, so you have my mail and personal info, if anything is not clear with the experience I'm trying to explain please reach out. The bottom line from my point of view is that version 4 worked as desired and there's a problem with version 5. If this is intentional and you want to nudge people to install the app this is totally acceptable, but it's not written anywhere as far I can see, so I'm expecting the version 4 behavior to remain from my developer experience. |
|
@thomasrockhu-codecov this appears to be resolved in my https://github.com/wbaldoumas/markdown-colorcode repository. Re-run worked fine today on v5. Thank you for all of your work! |
|
Hi, i have another pr without comment now. nonebot/adapter-onebot#121 I have tried to re-run the actions, the uploads are all successfull. The upload files can also be found at the webpage, but there is no comment. I have also tried to re-installed the codecov app. |
|
@yanyongyu hmmm, I'm not sure about this one. I'm seeing a No app found error on our backend, so I would have assumed it was something wrong with the GitHub app install. I need to ask the product team about what's going on there |
|
@yanyongyu are you able to do a |
i have rebase the pr and get the comment now. 👍🏻
No. I only found issue in this pr. All other prs are ok. |
|
@yanyongyu ok you should be good for now then |
|
@thomasrockhu-codecov was everything changed in order to solve this issue? |
|
@HarelM sorry I lost that thread. I need to investigate your instance in particular. One note, it is possible to turn off the status checks from Codecov so that you only get a comment by setting that in the |
|
Yeah... I don't have a codecov.yml file, I use the action only... :-) |
|
@HarelM got it, if you're open to PRs I'll write one up early next week |
|
Sure, feel free to use malibre-gl-js for testing. Just make sure to open draft PRs and have a good title so I'd know to ignore it. |
|
I've ask an org admin to uninstall the app and I don't get comments, so the issue here still exists. I'll ask her to install the app back as I need these comments. |
|
Also experiencing the same issue (status checks not reporting and PR's not being commented) as noted in #1712 |
Most of the dependabot PRs in my org updating from v4 to v5 do not have a codecov comment
But one does:
The text was updated successfully, but these errors were encountered: