Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make requirement that coverage *must* be in XML more obvious #456

Closed
ktbarrett opened this issue Jul 31, 2021 · 8 comments
Closed

Make requirement that coverage *must* be in XML more obvious #456

ktbarrett opened this issue Jul 31, 2021 · 8 comments
Assignees

Comments

@ktbarrett
Copy link

Spent a good hour on this until I realized that maybe everyone was running coverage xml for a reason. It is only implied and never out-right mentioned in the README.

@thomasrockhu-codecov thomasrockhu-codecov self-assigned this Aug 2, 2021
@trim21

This comment has been minimized.

@ktbarrett
Copy link
Author

I was specifying files: .coverage and it was being uploaded, but it was considered corrupt (I don't remember the exact error message at this point).

@trim21

This comment has been minimized.

@trim21
Copy link

trim21 commented Aug 14, 2021 via email

@jacksonj04
Copy link

The Python example suggests that codecov will run something called coveragexml for us which does this job:

Codecov will call coveragexml -i automatically to generate the coverage xml output, which will be archived and processed server side.

But this doesn't seem to actually be the case. Could the documentation be updated to clarify what actually needs to happen?

daniellockyer added a commit to TryGhost/framework that referenced this issue Oct 20, 2021
refs codecov/codecov-action#456

- turns out the coverage files need to be in XML for them to work with
  codecov, so this commit adds cobertura (XML) as a reporter
daniellockyer added a commit to TryGhost/framework that referenced this issue Oct 20, 2021
refs codecov/codecov-action#456

- turns out the coverage files need to be in XML for them to work with
  codecov, so this commit adds cobertura (XML) as a reporter
@dmail
Copy link

dmail commented Nov 2, 2021

Ah, good to know...

@dmail
Copy link

dmail commented Nov 2, 2021

It works fine with JSON for me:

[2021-11-02T07:58:05.090Z] ['info'] => Found 1 possible coverage files:
  ./coverage/coverage.json
[2021-11-02T07:58:05.090Z] ['verbose'] End of network processing
[2021-11-02T07:58:05.090Z] ['info'] Processing ./coverage/coverage.json...
[2021-11-02T07:58:05.094Z] ['info'] Using manual override from args.

image

@thomasrockhu-codecov
Copy link
Contributor

The uploader now runs coverage xml by default if coverage is installed (a dep of pytest-cov)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants