feat: fallback to tokenless on use_oidc if we can't find IDToken #1406
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1406 +/- ##
==========================================
+ Coverage 91.29% 91.31% +0.02%
==========================================
Files 4 4
Lines 310 311 +1
Branches 84 84
==========================================
+ Hits 283 284 +1
Misses 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| `Codecov: Failed to get OIDC token with url: ${url}. ${err.message}`, | ||
| true, | ||
| `Codecov: Failed to get OIDC token with url, uploading using tokenless: ${url}. ${err.message}`, | ||
| false, |
There was a problem hiding this comment.
I dont think we should silently fail this and go to tokenless. If anything, we should follow the failCi set.
There was a problem hiding this comment.
Actually on second thought, I don't know why we don't fail if we don't find OIDC. This is an opt-in feature.
There was a problem hiding this comment.
this makes sense for public repos that use OIDC for CI that run on branches on that repo, but may also receive forks from external contributors that won't have an id token, and will need to use tokenless
There was a problem hiding this comment.
@joseph-sentry please see #1404
There was a problem hiding this comment.
oh, missed that, that works, I'll close this one then!
Fixes: codecov/engineering-team#1574
Related: codecov/codecov-api#533