Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: isPullRequestFromFork returns false for any PR #1437

Merged
merged 7 commits into from
May 20, 2024
Merged

fix: isPullRequestFromFork returns false for any PR #1437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a250399
fix: isPullRequestFromFork returns false for any PR
shahar-h May 18, 2024
52bd105
fix: add log statement
thomasrockhu-codecov May 20, 2024
70a4cf0
fix: force set token
thomasrockhu-codecov May 20, 2024
09e1fe9
fix: pass in empty string
thomasrockhu-codecov May 20, 2024
7636613
fix: bump version
thomasrockhu-codecov May 20, 2024
a8a046d
fix: revert to promise
thomasrockhu-codecov May 20, 2024
4597db2
fix: revert changes
thomasrockhu-codecov May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
file: ./coverage/coverage-final.json
flags: version,${{ matrix.os }}
name: codecov-version
version: v0.2.0
version: v0.6.0
verbose: true
token: ${{ secrets.CODECOV_TOKEN }}

Expand Down Expand Up @@ -85,7 +85,7 @@ jobs:
file: ./coverage/coverage-final.json
flags: version,maxos-latest-xlarge
name: codecov-version
version: v0.2.0
version: v0.6.0
verbose: true
token: ${{ secrets.CODECOV_TOKEN }}

Expand Down Expand Up @@ -125,6 +125,6 @@ jobs:
file: ./coverage/coverage-final.json
flags: version,${{ matrix.os }}
name: codecov-version
version: v0.2.0
version: v0.6.0
verbose: true
token: ${{ secrets.CODECOV_TOKEN }}
3 changes: 2 additions & 1 deletion dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32340,7 +32340,8 @@ const getGitService = () => {
return 'github';
};
const isPullRequestFromFork = () => {
if (`${context.eventName}` !== 'pull_request' ||
core.info(`evenName: ${context.eventName}`);
if (`${context.eventName}` !== 'pull_request' &&
`${context.eventName}` !== 'pull_request_target') {
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion src/buildExec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,9 @@ const getGitService = (): string => {
};

const isPullRequestFromFork = (): boolean => {
core.info(`evenName: ${context.eventName}`);
if (
`${context.eventName}` !== 'pull_request' ||
`${context.eventName}` !== 'pull_request' &&
`${context.eventName}` !== 'pull_request_target'
) {
return false;
Expand Down