-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull in bash script and bump to 1.5.0 #299
Conversation
c946d61
to
9f471fc
Compare
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
==========================================
+ Coverage 97.02% 97.14% +0.11%
==========================================
Files 4 3 -1
Lines 168 140 -28
Branches 47 43 -4
==========================================
- Hits 163 136 -27
+ Misses 5 4 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I love this idea. It does seem strange that two different copies of the codecov bash script have to be checked into the repo at once. |
@briansmith yeah I noticed this at publishing time, and it definitely is a little strange. I'll work on making it more DRY and automated. |
@thomasrockhu -- in light of the bash uploader security issue (https://about.codecov.io/security-update/), looking for a bit more detail on if this change set is related to / part of the remediation in any way? Basically just trying to confirm if GitHub actions for uploading coverage results were impacted. |
@recursivelycurious, this change set is in fact related and is part of the remediation. The Codecov Action for uploading coverage results was impacted. I would recommend reaching out to security@codecov.io for any specific questions. |
Remove bash script curl dependency