-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add deep deps #424
fix: Add deep deps #424
Conversation
Codecov Report
@@ Coverage Diff @@
## master #424 +/- ##
==========================================
+ Coverage 96.52% 97.34% +0.82%
==========================================
Files 3 3
Lines 115 113 -2
Branches 34 34
==========================================
- Hits 111 110 -1
+ Misses 4 3 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
d6f9d18
to
ec0439a
Compare
d7a0e59
to
d5b33d5
Compare
d5b33d5
to
fc5d663
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a lot of files in ere that I don't think are needed, but lets get it working first. 👍
I'm going to follow up on this and investigate why this issue is occurring. I suspected it was due to asn1.js being declared as the wrong type of dependency— With regards to tracking node_modules in the repository, the GitHub Actions documentation recommends doing so for most Node.js projects that run on the platform. At the very least, the practice is not without merit. |
Adding a
dist/node_modules
folder due to issues withopenpgp
. This will likely be resolved when they release5.0.0
. It's not the most elegant way, but it works for now. See vercel/ncc#538Fixes #423