Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env vars #64

Merged
merged 8 commits into from
May 6, 2020
Merged

Env vars #64

merged 8 commits into from
May 6, 2020

Conversation

samuelcolvin
Copy link
Contributor

fix #63

This can be seen working here (see the windows and macos builds).

@ibrahim0814
Copy link
Contributor

Great idea! This PR LGTM, will merge and release a new version of this Action next week.

@samuelcolvin
Copy link
Contributor Author

I've just noticed a typo take -> tag in two places. I'll fix tomorrow.

@ibrahim0814
Copy link
Contributor

Thanks!

@samuelcolvin
Copy link
Contributor Author

done, vscode has also got bossy and striped trailing whitespace which shouldn't have been there anyway.

@samuelcolvin
Copy link
Contributor Author

@ibrahim0814 any chance this could get merged and released?

@samuelcolvin
Copy link
Contributor Author

@ibrahim0814 bump.

What's happening here?

Is codecov is still operating?

I'm making an open source contribution to a commercial company! Have the decency and good sense to reply in days not weeks.

@samuelcolvin
Copy link
Contributor Author

@ibrahim0814 @stevepeak this is very frustrating, what's happening here?

@stevepeak
Copy link

@samuelcolvin I apologize for the lack of response here. @drazisil and @thomasrockhu can jump on this. I have since stepped down from Codecov to work on other projects. Thank you!

@thomasrockhu
Copy link
Contributor

Hi @samuelcolvin I appreciate your patience and lack of response. I'll take a look at this today/tomorrow.

index.js Outdated Show resolved Hide resolved
@thomasrockhu thomasrockhu merged commit f532c3a into codecov:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adding environment variables
4 participants