1577 use users measurements #539
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
=====================================
Coverage 95.78 95.78
=====================================
Files 777 777
Lines 17254 17253 -1
=====================================
- Hits 16526 16525 -1
Misses 728 728
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
==========================================
+ Coverage 91.29% 91.30% +0.01%
==========================================
Files 601 600 -1
Lines 15979 15935 -44
==========================================
- Hits 14588 14550 -38
+ Misses 1391 1385 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #539 +/- ##
==========================================
+ Coverage 91.29% 91.30% +0.01%
==========================================
Files 601 600 -1
Lines 15979 15935 -44
==========================================
- Hits 14588 14550 -38
+ Misses 1391 1385 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
requirements.in
Outdated
| @@ -20,7 +20,7 @@ factory-boy | |||
| fakeredis | |||
| freezegun | |||
| https://github.com/codecov/opentelem-python/archive/refs/tags/v0.0.4a1.tar.gz#egg=codecovopentelem | |||
| https://github.com/codecov/shared/archive/1dc95a2ac3c07ca211319e65a90ea35592c825c1.tar.gz#egg=shared | |||
| https://github.com/codecov/shared/archive/9ca2efbb2c109ecfe241143ecd1c6f38c3820a0b.tar.gz#egg=shared | |||
There was a problem hiding this comment.
Don't merge until updated to latest after this is merged, codecov/shared#214
Purpose/Motivation
Finally. This is the PR where we get to use the measurements partition table on API - there's one for worker coming soon.
Basically, we're inserting upload records on the user measurements table when we insert an upload. For this repo, that happens on the CLI endpoint where we create an upload record preemptively. We're replacing the setting/reading with the insert_user_measurements and query_user_measurements methods, standardized in shared to be later used in worker as well.
On top of that, I'm getting rid of the previous implementation/query that took ages as that's no longer needed. I'm deleting, replacing or adjusting the tests we previously used to adjust to the new implementation.
Links to relevant tickets
What does this PR do?
Include a brief description of the changes in this PR. Bullet points are your friend.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.