Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mypy rules to not do typed defs change on test files #554

Merged
merged 2 commits into from
May 9, 2024

Conversation

JerrySentry
Copy link
Contributor

All test functions are return None anyways, not much value to add that in every test function.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@JerrySentry JerrySentry requested a review from a team as a code owner May 9, 2024 19:16
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.78%. Comparing base (dbe28ab) to head (05c3ec0).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #554   +/-   ##
=====================================
  Coverage   95.78   95.78           
=====================================
  Files        777     777           
  Lines      17262   17254    -8     
=====================================
- Hits       16534   16526    -8     
  Misses       728     728           
Flag Coverage Δ
unit 91.29% <ø> (-0.23%) ⬇️
unit-latest-uploader 91.29% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (dbe28ab) to head (05c3ec0).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   91.52%   91.29%   -0.23%     
==========================================
  Files         602      601       -1     
  Lines       16406    15979     -427     
==========================================
- Hits        15015    14588     -427     
  Misses       1391     1391              
Flag Coverage Δ
unit 91.29% <ø> (-0.23%) ⬇️
unit-latest-uploader 91.29% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (dbe28ab) to head (05c3ec0).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   91.52%   91.29%   -0.23%     
==========================================
  Files         602      601       -1     
  Lines       16406    15979     -427     
==========================================
- Hits        15015    14588     -427     
  Misses       1391     1391              
Flag Coverage Δ
unit 91.29% <ø> (-0.23%) ⬇️
unit-latest-uploader 91.29% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Impacted file tree graph

@JerrySentry JerrySentry added this pull request to the merge queue May 9, 2024
Merged via the queue into main with commit 88eb3a1 May 9, 2024
19 of 22 checks passed
@JerrySentry JerrySentry deleted the may_09_mypy branch May 9, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants