Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove troubleshooting logs #557

Merged
merged 4 commits into from
May 13, 2024
Merged

Conversation

nora-codecov
Copy link
Contributor

Purpose/Motivation

Remove OIDC troubleshooting logs, keep one for low level monitoring

@nora-codecov nora-codecov requested a review from a team as a code owner May 10, 2024 22:00
@codecov-qa
Copy link

codecov-qa bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (7fc9bc5) to head (c32d3ec).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
- Coverage   91.32%   91.32%   -0.01%     
==========================================
  Files         599      599              
  Lines       15947    15930      -17     
==========================================
- Hits        14564    14548      -16     
+ Misses       1383     1382       -1     
Flag Coverage Δ
unit 91.32% <100.00%> (-0.01%) ⬇️
unit-latest-uploader 91.32% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (7fc9bc5) to head (c32d3ec).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
- Coverage   91.32%   91.32%   -0.01%     
==========================================
  Files         599      599              
  Lines       15947    15930      -17     
==========================================
- Hits        14564    14548      -16     
+ Misses       1383     1382       -1     
Flag Coverage Δ
unit 91.32% <100.00%> (-0.01%) ⬇️
unit-latest-uploader 91.32% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/authentication/repo_auth.py 98.50% <100.00%> (-0.09%) ⬇️
upload/helpers.py 94.56% <100.00%> (+0.25%) ⬆️

Impacted file tree graph

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.82%. Comparing base (7fc9bc5) to head (c32d3ec).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #557   +/-   ##
=====================================
  Coverage   95.82   95.82           
=====================================
  Files        777     777           
  Lines      17265   17248   -17     
=====================================
- Hits       16543   16527   -16     
+ Misses       722     721    -1     
Flag Coverage Δ
unit 91.32% <100.00%> (-0.01%) ⬇️
unit-latest-uploader 91.32% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nora-codecov nora-codecov added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit e8cbe70 May 13, 2024
21 of 22 checks passed
@nora-codecov nora-codecov deleted the nora/troubleshoot-oidc-with-logs branch May 13, 2024 22:40
JerrySentry pushed a commit that referenced this pull request May 15, 2024
* adding logs for debugging

* change log level from debug to info

* make token slice safer

* remove troubleshooting logs

Signed-off-by: JerrySentry <jerry.feng@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants