Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving upload metrics #562

Merged
merged 3 commits into from
May 15, 2024
Merged

Improving upload metrics #562

merged 3 commits into from
May 15, 2024

Conversation

trent-codecov
Copy link
Contributor

Purpose/Motivation

What is the feature? Why is this being done?
Add more metric info to sentry metrics on upload. Will allow more granular comparison with Shelter.

Links to relevant tickets

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@trent-codecov trent-codecov requested a review from a team as a code owner May 14, 2024 19:58
@codecov-staging
Copy link

codecov-staging bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.83%. Comparing base (83a5577) to head (5f88423).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #562     +/-   ##
=======================================
+ Coverage   95.82   95.83   +0.01     
=======================================
  Files        777     777             
  Lines      17258   17272     +14     
=======================================
+ Hits       16537   16551     +14     
  Misses       721     721             
Flag Coverage Δ
unit 91.33% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.33% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-qa
Copy link

codecov-qa bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (83a5577) to head (5f88423).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #562   +/-   ##
=======================================
  Coverage   91.32%   91.33%           
=======================================
  Files         599      599           
  Lines       15940    15954   +14     
=======================================
+ Hits        14558    14572   +14     
  Misses       1382     1382           
Flag Coverage Δ
unit 91.33% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.33% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (83a5577) to head (5f88423).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #562   +/-   ##
=======================================
  Coverage   91.32%   91.33%           
=======================================
  Files         599      599           
  Lines       15940    15954   +14     
=======================================
+ Hits        14558    14572   +14     
  Misses       1382     1382           
Flag Coverage Δ
unit 91.33% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.33% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
upload/helpers.py 94.56% <ø> (ø)
upload/views/bundle_analysis.py 98.52% <100.00%> (+0.06%) ⬆️
upload/views/commits.py 100.00% <100.00%> (ø)
upload/views/empty_upload.py 91.54% <100.00%> (+0.24%) ⬆️
upload/views/legacy.py 95.07% <ø> (ø)
upload/views/reports.py 100.00% <100.00%> (ø)
upload/views/test_results.py 98.38% <ø> (ø)
upload/views/upload_completion.py 100.00% <100.00%> (ø)
upload/views/uploads.py 99.05% <ø> (ø)

Impacted file tree graph

@trent-codecov trent-codecov added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit b37bd9d May 15, 2024
21 of 22 checks passed
@trent-codecov trent-codecov deleted the trent/upload-metrics-improve branch May 15, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants