-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving upload metrics #562
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #562 +/- ##
=======================================
+ Coverage 95.82 95.83 +0.01
=======================================
Files 777 777
Lines 17258 17272 +14
=======================================
+ Hits 16537 16551 +14
Misses 721 721
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #562 +/- ##
=======================================
Coverage 91.32% 91.33%
=======================================
Files 599 599
Lines 15940 15954 +14
=======================================
+ Hits 14558 14572 +14
Misses 1382 1382
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #562 +/- ##
=======================================
Coverage 91.32% 91.33%
=======================================
Files 599 599
Lines 15940 15954 +14
=======================================
+ Hits 14558 14572 +14
Misses 1382 1382
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Purpose/Motivation
What is the feature? Why is this being done?
Add more metric info to sentry metrics on upload. Will allow more granular comparison with Shelter.
Links to relevant tickets
What does this PR do?
Include a brief description of the changes in this PR. Bullet points are your friend.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.