fix scheduled details key w/ stripe version upgrade #563
Conversation
| && rm -rf frp.tar.gz \ | ||
| && mv frp_*_linux_amd64 /frp \ | ||
| && chown -R frp:frp /frp | ||
| SHELL ["/bin/bash", "-c"] |
There was a problem hiding this comment.
Unrelated change that helps run frp in api; doesn't break logic as it's only for local development
api/internal/owner/serializers.py
Outdated
|
|
||
|
|
||
| class ScheduleDetailSerializer(serializers.Serializer): | ||
| id = serializers.CharField() | ||
| scheduled_phase = serializers.SerializerMethodField() | ||
|
|
||
| def get_scheduled_phase(self, schedule): | ||
| print("le schedule", schedule) |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #563 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 599 599
Lines 15940 15940
=======================================
Hits 14558 14558
Misses 1382 1382
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
=====================================
Coverage 95.82 95.82
=====================================
Files 777 777
Lines 17258 17258
=====================================
Hits 16537 16537
Misses 721 721
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 599 599
Lines 15940 15940
=======================================
Hits 14558 14558
Misses 1382 1382
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* fix scheduled details key w/ stripe version upgrade * add other test case * remove print Signed-off-by: JerrySentry <jerry.feng@sentry.io>
* fix scheduled details key w/ stripe version upgrade * add other test case * remove print Signed-off-by: JerrySentry <jerry.feng@sentry.io>
Purpose/Motivation
We recently majorly bumped our stripe version and some api calls stopped working. This fixes the scheduled detail serializer one.
What does this PR do?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.