Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flip default value on upload_token_required_for_public_repos #965

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

nora-codecov
Copy link
Contributor

Purpose/Motivation

when true tokenless goes live we will merge this, which will make true tokenless default to "on" for new orgs.

Links to relevant tickets

codecov/engineering-team#2623

@nora-codecov nora-codecov requested review from a team as code owners November 8, 2024 00:13
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This PR includes changes to shared. Please review them here: codecov/shared@ebafd80...c5a9416

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.03%. Comparing base (efbf1e7) to head (6ced179).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
- Coverage   96.05%   96.03%   -0.02%     
==========================================
  Files         828      828              
  Lines       19166    19166              
==========================================
- Hits        18410    18407       -3     
- Misses        756      759       +3     
Flag Coverage Δ
unit 92.31% <ø> (-0.02%) ⬇️
unit-latest-uploader 92.31% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

This PR includes changes to shared. Please review them here: codecov/shared@26f0db0...9c31870

Copy link
Contributor

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@nora-codecov nora-codecov added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit ff80060 Nov 14, 2024
17 of 19 checks passed
@nora-codecov nora-codecov deleted the nora/2623 branch November 14, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants