Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Default for test suites and flags #975

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix: Default for test suites and flags #975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions graphql_api/types/test_analytics/test_analytics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@
if term:
testsuites = testsuites.filter(pl.col("testsuite").str.starts_with(term))

return testsuites.to_series().to_list()
return testsuites.to_series().drop_nulls().to_list() or []

Check warning on line 288 in graphql_api/types/test_analytics/test_analytics.py

View check run for this annotation

Codecov Notifications / codecov/patch

graphql_api/types/test_analytics/test_analytics.py#L288 

Added line #L288 was not covered by tests


def get_flags(repoid: int, term: str | None = None, interval: int = 30) -> list[str]:
Expand All @@ -300,7 +300,7 @@
if term:
flags = flags.filter(pl.col("flags").str.starts_with(term))

return flags.to_series().to_list()
return flags.to_series().drop_nulls().to_list() or []

Check warning on line 303 in graphql_api/types/test_analytics/test_analytics.py

View check run for this annotation

Codecov Notifications / codecov/patch

graphql_api/types/test_analytics/test_analytics.py#L303 

Added line #L303 was not covered by tests


class TestResultsOrdering(TypedDict):
Expand Down
Loading