Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Add content-length header for 411s #374

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Add content-length header for 411s #374

merged 1 commit into from
Nov 6, 2020

Conversation

thomasrockhu
Copy link
Contributor

@thomasrockhu thomasrockhu commented Nov 6, 2020 •
edited
Loading

Purpose

Users having been getting 411s, this addresses that issue.

Fixes #365

Notable Changes

None

Tests and Risks?

None

Update the SHA hash files

Done

@thomasrockhu thomasrockhu requested a review from a team November 6, 2020 04:37
drazisil-codecov
drazisil-codecov approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@drazisil-codecov drazisil-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like a content length of zero should break things. As long as you tested this.

@thomasrockhu
Copy link
Contributor Author

only on GET calls, POST can be 0

@thomasrockhu thomasrockhu merged commit 7da7d6c into master Nov 6, 2020
@thomasrockhu thomasrockhu deleted the content-length branch November 6, 2020 13:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drazisil-codecov drazisil-codecov drazisil-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

S3 upload broken: "Error 411 (Length Required)!!1"
2 participants
@thomasrockhu @drazisil-codecov