Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Do merge sha work for Azure as it runs detached head #395

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

thomasrockhu
Copy link
Contributor

Purpose

Azure Pipelines also runs in a detached head (like GitHub Actions). So this pulls the correct commit SHA

Notable Changes

This should fix an issue with users on Azure Pipelines

Tests and Risks?

Locally tested

Update the SHA hash files

Done

@thomasrockhu thomasrockhu requested a review from a team December 20, 2020 21:40
@codecov
Copy link

codecov bot commented Dec 20, 2020

Codecov Report

Merging #395 (551e358) into master (11c8610) will decrease coverage by 0.13%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   50.34%   50.20%   -0.14%     
==========================================
  Files           5        5              
  Lines        1452     1452              
==========================================
- Hits          731      729       -2     
- Misses        721      723       +2     
Impacted Files Coverage Δ
codecov 61.26% <81.81%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11c8610...551e358. Read the comment docs.

Copy link
Contributor

@drazisil-codecov drazisil-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to get a test for this case?

@thomasrockhu
Copy link
Contributor Author

@drazisil-codecov yeah I should, BUT I'm going to defer to another PR. I'm thinking of restructuring the entire script to be easier to test.

@thomasrockhu thomasrockhu merged commit 767d14b into master Dec 21, 2020
@thomasrockhu thomasrockhu deleted the azure-merge branch December 21, 2020 03:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants