This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Allow paths with globs in -f #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
==========================================
+ Coverage 48.55% 50.27% +1.71%
==========================================
Files 5 5
Lines 1423 1456 +33
==========================================
+ Hits 691 732 +41
+ Misses 732 724 -8
Continue to review full report at Codecov.
|
|
BTW this issue was already reported at least in the codecov github action repository: codecov/codecov-action#144 |
Most options dealing with specifying files can deal with paths/with/*/globs correctly by using the -path find option instead of -name, except for -f (and only for inclusions, exclusions already use -path). It seems to make sense to allow globs in full paths too for inclusions (globs are already supported, but they will match any file recursively).
thomasrockhu
approved these changes
Jan 21, 2021
|
Thanks @llucax |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Allowing
-f path/*/globto work as expected (find files as the shell would when using that sort of glob). This also provides a more uniform interface as most options dealing with specifying files can deal with it in the expected way (even using the -f option to specify exclusions, like -f !path/*/glob, work).Notable Changes
Just use -path instead of -name as an option to find when -f is used for inclusions (as said before, for exclusions is already used).
Tests and Risks?
Tests are not provided as I didn't see any tests for any other -f use case, but maybe I just missed them? I looked in the
tests/testfile. I'm not familiar enough with shunit to add tests -f myself.There is the risk of surprising some user that is writing some coverage report to some path that includes a literal
*as part of the path and that have other files that will now match the glob and are not wanted in the codecov report upload.So something like:
-f path/*/globin a project producing the following files:Now will only find the file
path/*/globand with this change it will findpath/to/globtoo.But this looks like a very unlikely scenario.