Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Add upload only for bash uploader #403

Merged
merged 36 commits into from
Jan 27, 2021
Merged

Add upload only for bash uploader #403

merged 36 commits into from
Jan 27, 2021

Conversation

thomasrockhu
Copy link
Contributor

@thomasrockhu thomasrockhu commented Jan 25, 2021

Purpose

For users that have dumped the raw file from the Ruby uploader or from the bash uploader, have a path to only upload

Notable Changes

None

Tests and Risks?

None

Update the SHA hash files

Done

@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #403 (12198f1) into master (54b1a92) will decrease coverage by 7.52%.
The diff coverage is 62.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   48.52%   40.99%   -7.53%     
==========================================
  Files           5       20      +15     
  Lines        1424     2471    +1047     
==========================================
+ Hits          691     1013     +322     
- Misses        733     1458     +725     
Flag Coverage Δ
test 39.22% <44.92%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
codecov 64.05% <62.31%> (+4.59%) ⬆️
examples/mkdir_test.sh 0.00% <0.00%> (ø)
shunit2_standalone_test.sh 0.00% <0.00%> (ø)
examples/party_test.sh 0.00% <0.00%> (ø)
examples/equality_test.sh 0.00% <0.00%> (ø)
examples/lineno_test.sh 0.00% <0.00%> (ø)
shunit2_asserts_test.sh 0.00% <0.00%> (ø)
shunit2_macros_test.sh 0.00% <0.00%> (ø)
examples/math_test.sh 0.00% <0.00%> (ø)
shunit2_misc_test.sh 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b1a92...12198f1. Read the comment docs.

@thomasrockhu thomasrockhu changed the title Attempt Ruby coverage upload Add upload only for bash uploader Jan 25, 2021
@thomasrockhu thomasrockhu requested a review from a team January 25, 2021 23:31
@thomasrockhu thomasrockhu marked this pull request as ready for review January 25, 2021 23:31
Copy link
Contributor

@drazisil-codecov drazisil-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build failed

@thomasrockhu
Copy link
Contributor Author

Whoops @drazisil-codecov forgot about shellcheck

Copy link
Contributor

@drazisil-codecov drazisil-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write some tests? I afraid that things might break

@thomasrockhu thomasrockhu merged commit 5de0eef into master Jan 27, 2021
@thomasrockhu thomasrockhu deleted the use-ruby-formatter branch January 27, 2021 17:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants