Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Network prefix filter #412

Merged
merged 3 commits into from
Feb 26, 2021
Merged

Network prefix filter #412

merged 3 commits into from
Feb 26, 2021

Conversation

thomasrockhu
Copy link
Contributor

Purpose

Adds a flag that filters out files from the TOC. This will hopefully help with path fixing

Notable Changes

None

Tests and Risks?

Yup

Update the SHA hash files

Done

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #412 (7877012) into master (fb8663d) will increase coverage by 0.99%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
+ Coverage   44.70%   45.70%   +0.99%     
==========================================
  Files          20       20              
  Lines        2863     2862       -1     
==========================================
+ Hits         1280     1308      +28     
+ Misses       1583     1554      -29     
Flag Coverage Δ
test 39.22% <62.50%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
codecov 67.18% <75.00%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb8663d...7877012. Read the comment docs.

@thomasrockhu thomasrockhu requested a review from a team February 26, 2021 13:46
@thomasrockhu thomasrockhu changed the title Network prefix Network prefix filter Feb 26, 2021
Copy link
Contributor

@drazisil-codecov drazisil-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I offer a suggestion here that we start moving to long-form arguments with this change? In addition to reducing dependence on our dwindling supply of single char flags, it proved all users with easier to remember flags that share a connection to their use.

Instead of -h = "Don't run xcode if you detect gcov on the system and the file appears to be an Objective-C app for the iPod V series"

@thomasrockhu thomasrockhu merged commit 7100762 into master Feb 26, 2021
@thomasrockhu thomasrockhu deleted the network-prefix branch February 26, 2021 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants