This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Causes the correct server URL to be set in GitHub Actions. #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debayande
force-pushed
the
fix/use-correct-github-server-url
branch
2 times, most recently
from
731a331 to
a50254e
Compare
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
+ Coverage 45.73% 45.95% +0.22%
==========================================
Files 20 20
Lines 2858 2853 -5
==========================================
+ Hits 1307 1311 +4
+ Misses 1551 1542 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
debayande
force-pushed
the
fix/use-correct-github-server-url
branch
2 times, most recently
from
eb10a97 to
8a3e0b3
Compare
debayande
force-pushed
the
fix/use-correct-github-server-url
branch
from
8a3e0b3 to
f8530b1
Compare
Signed-off-by: Debayan De <debayande@users.noreply.github.com>
Signed-off-by: Debayan De <debayande@users.noreply.github.com>
debayande
force-pushed
the
fix/use-correct-github-server-url
branch
from
f8530b1 to
a5fc10f
Compare
|
Superceded by #457 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Debayan De debayande@users.noreply.github.com
Purpose
As a part of its routine for auto-detecting the underlying CI engine, the Bash uploader sets the
build_urlparameter tohttp://github.com/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}in L875 upon detecting GitHub Actions as the CI engine.While this works fine for github.com, it breaks uploads with HTTP 500 errors when run on GitHub Enterprise, GitHub's self-hosted sibling.
This patch, if applied, will fix the aforementioned issue (which is filed as #440).
Notable Changes
No.
Tests and Risks?
This should be covered by existing tests.
Update the SHA hash files
Done.