-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tokenless upload is being used when token is available #460
Comments
We're having what seems to be a related issue (modulo the fact that we don't have the secret in plaintext) over at https://github.com/facebook/Ax and https://github.com/pytorch/botorch. Our setup worked with 0.6.0 but broke with 0.7.0. Interestingly, the uploader correctly recognizes that "The PR is happening in a forked repo. Using tokenless upload." but then proceeds to error out that the token is not found:
Our config lives here: https://github.com/facebook/Ax/blob/main/.github/workflows/reusable_test.yml#L64-L70 |
Changes have made upload from forked repos fail, see codecov/codecov-cli#460 (comment) for details. Pinning for now until resolved.
Changes have made upload from forked repos fail, see codecov/codecov-cli#460 (comment) for details. Pinning for now until resolved.
Hi, thanks for filing an issue! 0.7.0 is indeed broken :/ We've just released 0.7.1 with a fix, and 0.6.0 should work fine as well. Sorry for the inconvenience. |
Summary: Changes have made upload from forked repos fail, see codecov/codecov-cli#460 (comment) for details. Pinning for now until resolved. Pull Request resolved: #2533 Reviewed By: dme65 Differential Revision: D58875121 Pulled By: Balandat fbshipit-source-id: 54fe14fa4c348a5c9cc2c6084029cafebbc6d51a
Summary: Changes have made upload from forked repos fail, see codecov/codecov-cli#460 (comment) for details. Pinning for now until resolved. Pull Request resolved: #2385 Reviewed By: dme65 Differential Revision: D58875053 Pulled By: Balandat fbshipit-source-id: e3c1b3363f2a7bfd22c947ceab65bb60abdf162b
I can confirm that 0.7.1 works now. |
Summary: This was pinned in facebook#2533 to fix an issue with a broken codecov uploader 0.7.0, which has now been resolved in 0.7.1: codecov/codecov-cli#460 Differential Revision: D59112079
Summary: This was pinned in pytorch#2385 to fix an issue with a broken codecov uploader 0.7.0, which has now been resolved in 0.7.1: codecov/codecov-cli#460 Differential Revision: D59112225
Summary: Pull Request resolved: #2397 This was pinned in #2385 to fix an issue with a broken codecov uploader 0.7.0, which has now been resolved in 0.7.1: codecov/codecov-cli#460 Reviewed By: esantorella Differential Revision: D59112225 fbshipit-source-id: 9219812cc78ddee8e82b33a426f2af1c2d8a2f66
Summary: Pull Request resolved: #2547 This was pinned in #2533 to fix an issue with a broken codecov uploader 0.7.0, which has now been resolved in 0.7.1: codecov/codecov-cli#460 Reviewed By: esantorella Differential Revision: D59112079 fbshipit-source-id: 7956045276cc8efdb6ff7bb5d6fdede3c786c2d5
We have a public repo with the upload token stored in plaintext in GitHub Actions YAML configuration (because that's the best we can do given how secrets and even vars are working). We send PRs from public forks. v0.7.0, released several hours ago, broke our uploads:
I think the reason is somewhere between #447, codecov/codecov-action#1410, and codecov/codecov-action#1471. Weirdly, the last PR should supposedly fix our situation, but we still saw "Fork detected, tokenless uploading used" message in logs.
The text was updated successfully, but these errors were encountered: