feat+fix: preserve test collection order #346
Open
+158
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We run into issues with test ordering with some frequency in the ATS step in CI. This is because ATS scrambles the test order and this uncovers certain dependencies within tests. Sure there's some value in doing that, but fixing these issues is somewhat annoying and actually disrupts the workflow more than is helpful. Scrambling test order needs to be deliberate, not accidental These changes make sure that we preserve the order that pytest collected tests when deciding the order to run them. Notice that it can still run into ordering issues if a test that depends on another test does't get picked to run.
giovanni-guidini
requested review from
matt-codecov,
adrian-codecov and
joseph-sentry
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
==========================================
- Coverage 95.52% 95.47% -0.05%
==========================================
Files 80 80
Lines 2746 2764 +18
==========================================
+ Hits 2623 2639 +16
- Misses 123 125 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@ai-review-prompt-prod testing AI code review, you can ignore the feedback (if any). |
![codecov-ai[bot]](https://avatars.githubusercontent.com/in/797565?s=60&v=4){kind=small}
Comment on lines
+24
to
+30
| @property | ||
| def collected_labels_in_order(self) -> List[str]: | ||
| """The list of collected labels, in the order returned by the testing tool. | ||
| This is a superset of all other lists. | ||
| """ | ||
| return self.get("collected_labels_in_order", []) | ||
|
|
There was a problem hiding this comment.
The collected_labels_in_order property should be moved to the end of the class to maintain the logical grouping of methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run into issues with test ordering with some frequency in the ATS
step in CI. This is because ATS scrambles the test order and this
uncovers certain dependencies within tests.
Sure there's some value in doing that, but fixing these issues is
somewhat annoying and actually disrupts the workflow more than is
helpful. Scrambling test order needs to be deliberate, not accidental
These changes make sure that we preserve the order that pytest
collected tests when deciding the order to run them.
Notice that it can still run into ordering issues if a test that
depends on another test does't get picked to run.