Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search acceptable paths for codecov yaml if not passed in #368

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

matt-codecov
Copy link
Contributor

fixes #365

the node uploader searched for a codecov yaml in one of 12 paths. this PR searches the same 12 paths when looking for the codecov yaml on startup

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (019a55a) 95.94% compared to head (4d6239f) 96.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
+ Coverage   95.94%   96.01%   +0.07%     
==========================================
  Files          81       81              
  Lines        2789     2813      +24     
==========================================
+ Hits         2676     2701      +25     
+ Misses        113      112       -1     
Flag Coverage Δ
python3.10 96.30% <100.00%> (+0.06%) ⬆️
python3.11 96.30% <100.00%> (+0.06%) ⬆️
python3.8 96.27% <96.77%> (+0.03%) ⬆️
python3.9 96.27% <96.77%> (+0.03%) ⬆️
smart-labels 96.01% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I don't really like all the empty codecov.ymls in the project though. I'd suggest using tempfile to create a fake project structure on-the-fly
(and use pytest.mark.parametrize)

But you know, small suggestion that should not prevent this from being merged.

@matt-codecov matt-codecov merged commit a27c573 into main Feb 2, 2024
18 checks passed
@matt-codecov matt-codecov deleted the matt/detect-codecov-yaml-paths branch February 2, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI does not detect codecov.yml files from allowed locations
2 participants