This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Fix broken gcov command #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
==========================================
- Coverage 90.16% 83.78% -6.39%
==========================================
Files 23 22 -1
Lines 356 370 +14
Branches 85 92 +7
==========================================
- Hits 321 310 -11
- Misses 35 49 +14
- Partials 0 11 +11
Continue to review full report at Codecov.
|
|
Ping? |
|
Sure, updated, thanks for the review! Do note that I forgot what I was trying to do 6 months ago that was broken, so I wasn't able to test that it fixed my particular use case this time. It seems like this approach ought to have the same effect, though. |
The gcov command can't be generated if none of the gcov options are given on the command line, since sanitizeVar() will throw an exception when given 'undefined' as input. This allows sanitizeVar() to accept an input of 'undefined'.
thomasrockhu
approved these changes
Sep 9, 2020
This was referenced Sep 6, 2024
This was referenced Sep 13, 2024
This was referenced Sep 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gcov command can't be generated if none of the gcov options are
given on the command line, since sanitizeVar() will throw an exception
when given 'undefined' as input. This runs sanitizeVar only if the
options are actually given.