-
Notifications
You must be signed in to change notification settings - Fork 139
Conversation
This is a follow up of the discussion in: https://community.codecov.com/t/add-support-of-uploading-from-cirrus-ci-without-token/1028/34 and uses the bash uploader as a reference: https://github.com/codecov/codecov-bash/blob/master/codecov#L959
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
=====================================
Coverage 58% 58%
=====================================
Files 3 3
Lines 436 439 +3
Branches 106 107 +1
=====================================
+ Hits 255 259 +4
+ Misses 125 124 -1
Partials 56 56 |
I think this is missing unit tests. |
Thank you very much @nmoinvaz. To me they look like they actually expect to run in the given CI, instead of just posting data that the codecov server can verify from existing builds (I can be very wrong here, I really had troubles understanding the existing test suite). If you can guide me through the process, I am more than happy to add the missing tests. |
Unit tests can be found in Line 554 in 51469b0
It simply sets up the environment using example environment key value pairs. Then it ensures that the proper values are parsed from the environment variables after it runs |
Take a look at my PR for example: |
Yes, I did see this code, but it is exactly the code that I was having trouble to understand. But I think now I understand now what is happening... The decorators are there just to make sure the tests are not executed more than once, isn't it? Once the test runs, it changes the env vars, and then the decorators are there to make sure the same test does not run again? I think now I might be able to give it a shot. Thank you (I should follow up shortly). |
Tests added, hopefully they will pass in the CI, since I just ported them from the bash exporter 🤞 |
Good idea about using the bash ones. @thomasrockhu can you start the workflows? |
LGTM, will deploy a new version sometime this week. Just a note, we will be deprecating support for this uploader in the next few months in favor of our new uploader |
Hello, this is a follow up of the discussion in:
https://community.codecov.com/t/add-support-of-uploading-from-cirrus-ci-without-token/1028/34
and uses the bash uploader as a reference:
https://github.com/codecov/codecov-bash/blob/master/codecov#L959