Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

remove the py26 dependency on python-future #57

Merged
merged 1 commit into from
Mar 24, 2016

Conversation

bukzor
Copy link
Contributor

@bukzor bukzor commented Feb 17, 2016

Python-future is problematic because of PythonCharmers/python-future#148

When I add codecov to my python project, my py26 test suite starts failing because of this above bug and my new transitive dependency on python-future.

Testing done:

$ tox                                                                                                                                    [34/2331]
GLOB sdist-make: /nail/home/buck/trees/mine/codecov-python/setup.py
py26 inst-nodeps: /nail/home/buck/trees/mine/codecov-python/.tox/dist/codecov-1.6.5.zip
py26 runtests: PYTHONHASHSEED='3117039750'
py26 runtests: commands[0] | py.test tests/test.py
========================================================================================== test session starts ===========================================================================================
platform linux2 -- Python 2.6.7, pytest-2.8.7, py-1.4.31, pluggy-0.3.1
rootdir: /nail/home/buck/trees/mine/codecov-python, inifile:
plugins: cov-2.2.1
collected 68 items

tests/test.py ...................s....s.......................................s...

================================================================================== 65 passed, 3 skipped in 3.66 seconds ==================================================================================
py27 inst-nodeps: /nail/home/buck/trees/mine/codecov-python/.tox/dist/codecov-1.6.5.zip
py27 runtests: PYTHONHASHSEED='3117039750'
py27 runtests: commands[0] | py.test tests/test.py
========================================================================================== test session starts ===========================================================================================
platform linux2 -- Python 2.7.6, pytest-2.8.7, py-1.4.31, pluggy-0.3.1
rootdir: /nail/home/buck/trees/mine/codecov-python, inifile:
plugins: cov-2.2.1
collected 68 items

tests/test.py ...................s....s.......................................s...

================================================================================== 65 passed, 3 skipped in 3.62 seconds ==================================================================================
py34 inst-nodeps: /nail/home/buck/trees/mine/codecov-python/.tox/dist/codecov-1.6.5.zip
py34 runtests: PYTHONHASHSEED='3117039750'
py34 runtests: commands[0] | py.test tests/test.py
========================================================================================== test session starts ===========================================================================================
platform linux -- Python 3.4.2, pytest-2.8.7, py-1.4.31, pluggy-0.3.1
rootdir: /nail/home/buck/trees/mine/codecov-python, inifile:
plugins: cov-2.2.1
collected 68 items

tests/test.py ...................s....s.......................................s...

================================================================================== 65 passed, 3 skipped in 3.83 seconds ==================================================================================
________________________________________________________________________________________________ summary _________________________________________________________________________________________________
  py26: commands succeeded
  py27: commands succeeded
  py34: commands succeeded
  congratulations :)

@codecov-io
Copy link

Current coverage is 83.38%

Merging #57 into master will decrease coverage by -0.42% as of b3bcaff

@@            master     #57   diff @@
======================================
  Files            1       1       
  Stmts          315     319     +4
  Branches        72      69     -3
  Methods          0       0       
======================================
+ Hit            264     266     +2
- Partial         15      16     +1
- Missed          36      37     +1

Review entire Coverage Diff as of b3bcaff

Powered by Codecov. Updated on successful CI builds.

@bukzor
Copy link
Contributor Author

bukzor commented Feb 18, 2016

.

@bukzor
Copy link
Contributor Author

bukzor commented Feb 18, 2016

I don't believe this patch broke appveyor/windows. Is that possible?

@bukzor
Copy link
Contributor Author

bukzor commented Feb 19, 2016

I believe appveyor is simply broken for master branch.
It most recently passed more than four months ago: https://ci.appveyor.com/project/stevepeak/codecov-python/history

@stevepeak stevepeak merged commit 42f7118 into codecov:master Mar 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants