-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support aarch64 / arm64 arch #523
Comments
CircleCI does not yet support M1 builds. |
@drazisil-codecov this ticket is about Linux ARM Support, that is supported in CircleCI, see https://circleci.com/execution-environments/arm/ we even have a job for it running in https://github.com/dotpcap/sharppcap/blob/master/.circleci/config.yml#L42 |
Cirrus CI is migrating already from Intel to M1: https://cirrus-ci.org/blog/2022/11/08/sunsetting-intel-macos-instances/ |
Cirrus CI is moving to M1 (arm64), Codecov uploader still doesn't support it: codecov/uploader#523 (comment)
Cirrus CI is moving to M1 (arm64), Codecov uploader still doesn't support it: codecov/uploader#523 (comment)
Is there any motion on this? We're trying to use codecov on CircleCI ARM executors |
The python uploader is now phased out [1] The new uploader is a binary executable for x86-64 (amd64), so there is no simple way of running it for arm64. However, the arm64 build for small tests shouldn't affect coverage anyway (the tests are exactly the same as for amd64), so it is just skipped for now util the uploader supports this arch, see issue [2] CODECOV_TOKEN needs to be used now because of issue [3] 1. https://docs.codecov.com/docs/deprecated-uploader-migration-guide#python-uploader 2. codecov/uploader#523 3. https://community.codecov.com/t/commit-sha-does-not-match-circle-build/4266
The python uploader is now phased out [1] The new uploader is a binary executable for x86-64 (amd64), so there is no simple way of running it for arm64. However, the arm64 build for small tests shouldn't affect coverage anyway (the tests are exactly the same as for amd64), so it is just skipped for now until the uploader supports this arch, see issue [2] CODECOV_TOKEN needs to be used now because of issue [3] 1. https://docs.codecov.com/docs/deprecated-uploader-migration-guide#python-uploader 2. codecov/uploader#523 3. https://community.codecov.com/t/commit-sha-does-not-match-circle-build/4266
@andyleclair I got a PR out here which will hopefully create the right build. |
Nice! I'm out on paternity leave right now, but maybe @humberaquino could test it out for you all if you need that |
@humberaquino if you're willing I created an asset here (https://app.circleci.com/pipelines/github/codecov/uploader/4170/workflows/56ff966f-d2b7-43d1-9128-b6a59b0c23ba/jobs/40761/artifacts) named You should be able to download that file, |
Is there a new release with it? I mean, especially https://uploader.codecov.io/latest/macos/codecov I'm getting:
https://github.com/filewatcher/filewatcher/pull/257/checks?check_run_id=16174741063 |
@AlexWayfer, |
OK, still the same error: https://cirrus-ci.com/task/5491238154010624 |
@AlexWayfer did you also run |
Of course, the whole script: filewatcher/filewatcher@fbc99e2#diff-266f128a156070b8d24c519331ba96b1b3ef940eefcdc7b3202c6b0ac88fd29dL13-L23 |
@AlexWayfer I'm not too well-versed with CirrusCI, so I have a few comments, let me know if this makes any sense
|
Interesting observation. I had done task cache clearing, probably it has not helped. Now I've cleared cache of all the project. https://cirrus-ci.com/task/5628663048175616 Do I need to write something more specific? For example, @fkorotkov, I'd like to see your help if possible. |
Without cache, explicit script: https://cirrus-ci.com/task/5167047781384192?logs=codecov#L6 39 MB. Still Similar fresh report: #347 (comment) |
Going to handle the issue here: codecov/feedback#141 |
Is your feature request related to a problem? Please describe.
Currently the uploader does not work under arm64 docker images
Describe the solution you'd like
Support is needed.
Additional context
CircleCi machine executor running
--platform linux/arm64
when launching the docker image.@drazisil-codecov has more context
The text was updated successfully, but these errors were encountered: