Failed check and status messaging in comment, part III #1030
Conversation
…n user has defined a target
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1030 +/- ##
==========================================
- Coverage 97.71% 97.48% -0.23%
==========================================
Files 458 459 +1
Lines 37138 37303 +165
==========================================
+ Hits 36289 36365 +76
- Misses 849 938 +89
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
| # included_helper_text[CUSTOM_TARGET_TEXT] = helper_text | ||
| return state, message | ||
| if state == StatusState.failure.value: | ||
| helper_text = HELPER_TEXT_MAP[CUSTOM_TARGET_TEXT_PROJECT_KEY].format( |
There was a problem hiding this comment.
It looks like this HELPER_TEXT_MAP (see here) points both the patch and project keys to the same helper text, and "patch" is hard coded in that text
There was a problem hiding this comment.
ha! good catch - thank you. fixing.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This is the same as the last one (#1023) but for project rather than patch status and checks.
when user has:
project checks notifier OR project status notifier
AND
comment notifier
AND
has defined a target in their codecov yml
AND
the project check/status fails
THEN
add some helper text to the comment notifier to point out that the check/status failed and that they can change their target.
codecov/engineering-team#1605