Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout should not be required #1041

Merged
merged 1 commit into from
Jan 28, 2025
Merged

layout should not be required #1041

merged 1 commit into from
Jan 28, 2025

Conversation

nora-codecov
Copy link
Contributor

layout should be optional - docs here

it's not optional in code and popped up in sentry

Added a test to show what the comment looks like with no layout, using the defaults we have set in code.

@nora-codecov nora-codecov requested a review from a team January 28, 2025 21:55
Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@nora-codecov nora-codecov added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 2f7dc68 Jan 28, 2025
18 of 23 checks passed
@nora-codecov nora-codecov deleted the nora/1605-bug branch January 28, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants