fix: N+1 query for plans / tiers

[ajay-sentry]

This PR aims to fix an N+1 query that was introduced when swapping to the plan model as the source of truth from the consts in shared for the same.

Previously we were calling the plan query n number of times depending on how many values get returned in line 179 here:

worker/services/notification/__init__.py

Lines 179 to 185 in 2508bbc

	for key, title, status_config in self.get_statuses(current_flags):
	if self._should_use_status_notifier(status_type=key):
	yield self._use_status_and_possibly_checks_notifiers(
	key=key,
	title=title,
	status_config=status_config,
	)

This cascaded down to

worker/services/notification/__init__.py

Lines 93 to 94 in 2508bbc

	if not self.plan:
	self.plan = Plan.objects.select_related("tier").get(name=owner.plan)

and

worker/services/notification/__init__.py

Lines 73 to 74 in 2508bbc

	if not self.plan:
	self.plan = Plan.objects.select_related("tier").get(name=owner.plan)

where since plan wasn't persisted on the NotificationService we were calling the query every single time.

My fix is to persist the plan on the NotificationService object so if it exists we skip calling the query and just use that reference instead. I tested this against some of the existing UTs with prints to confirm the plan was persisted as I expected.

Closes https://github.com/codecov/internal-issues/issues/1195

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.52%. Comparing base (6302730) to head (2508bbc).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #1060    +/-   ##
========================================
  Coverage   97.52%   97.52%            
========================================
  Files         462      463     +1     
  Lines       37902    38037   +135     
========================================
+ Hits        36963    37095   +132     
- Misses        939      942     +3     

Flag	Coverage Δ
integration	42.85% <85.71%> (-0.04%)	⬇️
unit	90.20% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

⚠️ Impact Analysis from Codecov is deprecated and will be sunset on Jan 31 2025. See more

[codecov-notifications]

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

[github-actions]

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

[ajay-sentry]

this is a reference that was missed prior, it should be using the tier derived from the plan rather than a hard coded set of plans

[nora-codecov]

NICE

[nora-codecov]

NICE