Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add webhook failure/redelivery statistics #1066

Merged
merged 1 commit into from
Feb 6, 2025
Merged

add webhook failure/redelivery statistics #1066

merged 1 commit into from
Feb 6, 2025

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Feb 5, 2025

  • creates a counter for all webhooks (from github) that failed to be delivered, broken down by webhook event
  • creates a counter for webhook redelivery requests (to github), broken down by whether the request succeeded or not
  • reorganizes some logic to make the relationship between the filters and metrics clearer

ideally the redelivery counter would also have an event label, and both counters could have a label for the event. but i don't want to get too into this right now and it's not that important

right now we only do this webhook redelivery thing with github. not sure if other providers offer something similar, but if they do, the same counters have a "service" label and can be used

@matt-codecov matt-codecov requested a review from a team February 5, 2025 23:09
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (66d2b33) to head (f230561).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (66d2b33) and HEAD (f230561). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (66d2b33) HEAD (f230561)
unit 2 1
integration 2 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1066      +/-   ##
==========================================
- Coverage   97.53%   90.24%   -7.30%     
==========================================
  Files         466      466              
  Lines       38163    38176      +13     
==========================================
- Hits        37223    34451    -2772     
- Misses        940     3725    +2785     
Flag Coverage Δ
integration ?
unit 90.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

⚠️ Impact Analysis from Codecov is deprecated and will be sunset on Jan 31 2025. See more

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 5, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link

github-actions bot commented Feb 5, 2025

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@matt-codecov matt-codecov added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 44295bd Feb 6, 2025
24 of 27 checks passed
@matt-codecov matt-codecov deleted the pr1066 branch February 6, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants