refactor: improve test results finisher notify logic

[joseph-sentry]

we don't want to even try to notify if the pull is none, so i'm pushing that check out of the Notifier.notify() and overriding the base notify in the TestResultsNotifier, to expect a Pull

[sentry-io]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: tasks/test_results_finisher.py

Function	Unhandled Issue
process_impl_within_lock	Plan.DoesNotExist: Plan matching query does not exist. app.tasks.test_results.TestResultsFinish... Event Count: 418

---

_{Did you find this useful? React with a 👍 or 👎}

[codecov]

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.53%. Comparing base (8f9ea48) to head (03673db).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
tasks/test_results_finisher.py	94.44%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1070   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files         466      466           
  Lines       38178    38192   +14     
=======================================
+ Hits        37237    37252   +15     
+ Misses        941      940    -1     

Flag	Coverage Δ
integration	42.88% <92.30%> (+0.02%)	⬆️
unit	90.21% <35.89%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

⚠️ Impact Analysis from Codecov is deprecated and will be sunset on Jan 31 2025. See more

[codecov-notifications]

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
tasks/test_results_finisher.py	94.44%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[github-actions]

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ AssertionError app.tasks.test_results.TAFinisher View Issue

_{Did you find this useful? React with a 👍 or 👎}