Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unused minio.periodic_callback_ms field #899

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

Swatinem
Copy link
Contributor

No description provided.

@Swatinem Swatinem requested a review from a team November 18, 2024 12:48
@Swatinem Swatinem self-assigned this Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.04%. Comparing base (c20baed) to head (e70fad4).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #899   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files         444      444           
  Lines       35435    35435           
=======================================
  Hits        34744    34744           
  Misses        691      691           
Flag Coverage Δ
integration 41.95% <ø> (ø)
unit 90.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.14% <ø> (ø)
OutsideTasks 95.94% <ø> (ø)
Files with missing lines Coverage Δ
conftest.py 95.00% <ø> (ø)
tasks/tests/unit/test_send_email_task.py 100.00% <ø> (ø)

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #899   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files         444      444           
  Lines       35435    35435           
=======================================
  Hits        34744    34744           
  Misses        691      691           
Flag Coverage Δ
integration 41.95% <ø> (ø)
unit 90.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.14% <ø> (ø)
OutsideTasks 95.94% <ø> (ø)
Files with missing lines Coverage Δ
conftest.py 95.00% <ø> (ø)
tasks/tests/unit/test_send_email_task.py 100.00% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.04%. Comparing base (c20baed) to head (e70fad4).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #899   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files         444      444           
  Lines       35435    35435           
=======================================
  Hits        34744    34744           
  Misses        691      691           
Flag Coverage Δ
integration 41.95% <ø> (ø)
unit 90.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.14% <ø> (ø)
OutsideTasks 95.94% <ø> (ø)
Files with missing lines Coverage Δ
conftest.py 95.00% <ø> (ø)
tasks/tests/unit/test_send_email_task.py 100.00% <ø> (ø)

Copy link

codecov-public-qa bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.04%. Comparing base (c20baed) to head (e70fad4).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #899   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files         444      444           
  Lines       35435    35435           
=======================================
  Hits        34744    34744           
  Misses        691      691           
Flag Coverage Δ
integration 41.95% <ø> (ø)
unit 90.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.14% <ø> (ø)
OutsideTasks 95.94% <ø> (ø)
Files with missing lines Coverage Δ
conftest.py 95.00% <ø> (ø)
tasks/tests/unit/test_send_email_task.py 100.00% <ø> (ø)

Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dunno what that is, but if it's not used 🤷

@Swatinem Swatinem added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 5339dd2 Nov 20, 2024
26 of 27 checks passed
@Swatinem Swatinem deleted the swatinem/cleanup-minio branch November 20, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants