fix: reset stream_id when the http2 connection is closed (#216)

codedge-llc · Nov 30, 2021 · bcace1d · bcace1d
1 parent 54735f8
commit bcace1d
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 3 deletions.
diff --git a/lib/pigeon/apns.ex b/lib/pigeon/apns.ex
@@ -206,7 +206,13 @@ defmodule Pigeon.APNS do
     case connect_socket(config) do
       {:ok, socket} ->
         Configurable.schedule_ping(config)
-        {:noreply, %{state | socket: socket}}
+
+        state =
+          state
+          |> reset_stream_id()
+          |> Map.put(:socket, socket)
+
+        {:noreply, state}
 
       {:error, reason} ->
         {:stop, reason}
@@ -251,4 +257,9 @@ defmodule Pigeon.APNS do
   def inc_stream_id(%{stream_id: stream_id} = state) do
     %{state | stream_id: stream_id + 2}
   end
+
+  @doc false
+  def reset_stream_id(state) do
+    %{state | stream_id: 1}
+  end
 end
diff --git a/lib/pigeon/fcm.ex b/lib/pigeon/fcm.ex
@@ -158,7 +158,13 @@ defmodule Pigeon.FCM do
     case connect_socket(config) do
       {:ok, socket} ->
         Configurable.schedule_ping(config)
-        {:noreply, %{state | socket: socket}}
+
+        state =
+          state
+          |> reset_stream_id()
+          |> Map.put(:socket, socket)
+
+        {:noreply, state}
 
       {:error, reason} ->
         {:stop, reason}
@@ -237,4 +243,9 @@ defmodule Pigeon.FCM do
   def inc_stream_id(%{stream_id: stream_id} = state) do
     %{state | stream_id: stream_id + 2}
   end
+
+  @doc false
+  def reset_stream_id(state) do
+    %{state | stream_id: 1}
+  end
 end
diff --git a/lib/pigeon/legacy_fcm.ex b/lib/pigeon/legacy_fcm.ex
@@ -239,7 +239,13 @@ defmodule Pigeon.LegacyFCM do
     case connect_socket(config) do
       {:ok, socket} ->
         Configurable.schedule_ping(config)
-        {:noreply, %{state | socket: socket}}
+
+        state =
+          state
+          |> reset_stream_id()
+          |> Map.put(:socket, socket)
+
+        {:noreply, state}
 
       {:error, reason} ->
         {:stop, reason}
@@ -284,4 +290,9 @@ defmodule Pigeon.LegacyFCM do
   def inc_stream_id(%{stream_id: stream_id} = state) do
     %{state | stream_id: stream_id + 2}
   end
+
+  @doc false
+  def reset_stream_id(state) do
+    %{state | stream_id: 1}
+  end
 end