Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove certfile and keyfile from APNS configurations #183

Merged
merged 3 commits into from
Jan 9, 2021
Merged

feat: remove certfile and keyfile from APNS configurations #183

merged 3 commits into from
Jan 9, 2021

Commits on Jan 9, 2021

  1. feat: remove certfile and keyfile from APNS configurations 

    Now configs should use the `:cert` and `:key` options by reading in the
raw contents of the file. This applies to both `APNS.Config` and
`APNS.JWTConfig`.

Also
- Moved pigeon's application module from `Pigeon` to
  `Pigeon.Application`
- Generated some valid (yet fake) certificates and keys for unit tests.
    @hpopp
    hpopp committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    2201dc1 View commit details
    Browse the repository at this point in the history

  2. fix: add fake certs and keys to tracking 

    Also: updated CHANGELOG with PR links
    @hpopp
    hpopp committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    3914651 View commit details
    Browse the repository at this point in the history

  3. fix: pass tests

    @hpopp
    hpopp committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    e25b55b View commit details
    Browse the repository at this point in the history