fix: use uri to make token storage key unique #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: allow httpoison 2.0 (codedge-llc#236) * fix: allow httpoison 2.0 * ci: fix workflows * ci: revert to ubuntu-latest * ci: use setup-beam@v1 * chore: update CHANGELOG * docs: update README links * fix: move token generation into Pigeon.APNS.Token (codedge-llc#227) This means the token is only generated once and used across all workers * chore: update CHANGELOG --------- Co-authored-by: Henry Popp <hpopp@users.noreply.github.com> Co-authored-by: Henry Popp <henry@codedge.io> Co-authored-by: Andrew Timberlake <andrew@andrewtimberlake.com>
* fix: allow httpoison 2.0 (codedge-llc#236) * fix: allow httpoison 2.0 * ci: fix workflows * ci: revert to ubuntu-latest * ci: use setup-beam@v1 * chore: update CHANGELOG * docs: update README links * fix: move token generation into Pigeon.APNS.Token (codedge-llc#227) This means the token is only generated once and used across all workers * chore: update CHANGELOG --------- Co-authored-by: Henry Popp <hpopp@users.noreply.github.com> Co-authored-by: Henry Popp <henry@codedge.io> Co-authored-by: Andrew Timberlake <andrew@andrewtimberlake.com>
…onfigurations don't conflict with each other
|
Is there anything I can do to get this reviewed? It's a relatively minor change but we are stuck using our fork until this gets consumed upstream. |
|
Thanks for the patch! Finally getting around to reviewing everything. I'll have this out in the next RC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed there was an issue where fetching tokens for our development pushes were causing some conflicts with our pushes to release devices. This is a simple fix to ensure that the token generated for
:devor:prodhave their own unique token lifecycle, since apple is finicky about how many times you request a token. It has been a bit since we made this fix but never got around to upstreaming it, so I forget the details on what error we were seeing a lot of.