Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Elixir 1.17 deprecation in Pigeon 1.6.x #262

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

nathany-copia
Copy link

@egze
Copy link
Contributor

egze commented Aug 6, 2024

Please merge it. cc @hpopp

@hpopp hpopp merged commit 6bc63f2 into codedge-llc:v1.6 Aug 8, 2024
@hpopp
Copy link
Member

hpopp commented Aug 8, 2024

Thanks!

@nathany-copia
Copy link
Author

Thank you!

@nathany-copia
Copy link
Author

We're using this until 1.6.3 comes out -- for anyone else who needs this patch.

# Waiting for Pigeon 1.6.x release with Elixir 1.17 support.
{:pigeon, "~> 1.6.2", github: "codedge-llc/pigeon", ref: "6bc63f2"},

@nathany-copia nathany-copia deleted the elixir branch August 12, 2024 17:29
@hpopp
Copy link
Member

hpopp commented Aug 12, 2024

Went ahead and published 1.6.3 🚀

@valerio-pizzichini
Copy link

@hpopp @nathany-copia Thank you very much for your work on this issue!
We are currently using the version 2.0.0 due to some nice features we have foreseen, would it be possible to add the same fixes on the master branch?

I can open a PR on master branch with the fix if you wish 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants