Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AquaSKK.xibのバージョンにProject Deployment Targetを使うように #90

Merged

Conversation

rinsuki
Copy link

@rinsuki rinsuki commented Feb 14, 2019

Xcode 10.1でビルド失敗したので

@banjun banjun self-assigned this Feb 14, 2019
@mzp
Copy link
Member

mzp commented Feb 15, 2019

.travis.yml のXcodeの更新がいるかも。

@banjun banjun changed the title AquaSKK.xibのバージョンにDeployment Targetを使うように AquaSKK.xibのバージョンにProject Deployment Targetを使うように Feb 15, 2019
@banjun
Copy link
Member

banjun commented Feb 15, 2019

PRありがとうございます👍

PR前の状態だと出るエラー:

aquaskk/platform/mac/proj/AquaSKK.xib:global: error: Compiling for earlier than macOS 10.6 is no longer supported. [12]

travisコケてるのはSKKAutoUpdateDictionary_TEST.cppであり,これはまた別の(潜在的に既存の)問題のようです。

@banjun banjun merged commit 2edf024 into codefirst:master Feb 15, 2019
@rinsuki
Copy link
Author

rinsuki commented Feb 15, 2019

openlabが死んでて辞書落とせてない話っぽさがある…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants