Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Due Date is confusing -- allow changes until midnight on the due date #384

Open
jtf621 opened this issue Dec 2, 2016 · 1 comment
Open

Comments

@jtf621
Copy link
Contributor

jtf621 commented Dec 2, 2016

Currently the due data for profile surveys is listed as a day, but the due date is a datetime that ends before midnight on the due date.

@flowersw
Copy link
Contributor

Here is what is currently in the model:

` def due_date(self):
first_survey_due_date = datetime.date(2016, 7, 29)
if datetime.date.today() < datetime.date(2016, 6, 30):
return first_survey_due_date
return (self.created_at + datetime.timedelta(30)).date()

def overdue(self):
    tomorrow = (timezone.now() + datetime.timedelta(days=1)).date()
    return self.due_date() < tomorrow

`

So, I think we just need to change the tomorrow variable to equal 11:59pm the next day. Does that sound right?

dsummersl pushed a commit to dsummersl/school-navigator that referenced this issue Oct 16, 2017
jtf621 added a commit that referenced this issue Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants